Skip to content

bug 2034484: feat: updated library-go and related deps#73

Merged
openshift-merge-robot merged 4 commits intoopenshift:masterfrom
eggfoobar:library_go_bump
Jan 3, 2022
Merged

bug 2034484: feat: updated library-go and related deps#73
openshift-merge-robot merged 4 commits intoopenshift:masterfrom
eggfoobar:library_go_bump

Conversation

@eggfoobar
Copy link
Copy Markdown
Contributor

@eggfoobar eggfoobar commented Dec 12, 2021

Bumping the library-go dependency to latest, this should take advantage of leader election changes for SNO clusters proposed in this library-go PR and performance improvements in this PR.

Changes:

  • updated library-go to latest
  • updated kubernetes to k8s libraries

Signed-off-by: ehila ehila@redhat.com

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 12, 2021
updated library-go to latest
updated kuberentes to k8s libraries

ran:
 go mod tidy && go mod vendor && go mod verify

Signed-off-by: ehila <ehila@redhat.com>

feat: updated logs to explicitly add flags

Signed-off-by: ehila <ehila@redhat.com>
@eggfoobar eggfoobar changed the title [WIP] feat: updated library-go and related deps feat: updated library-go and related deps Dec 15, 2021
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 15, 2021
Signed-off-by: ehila <ehila@redhat.com>
@eggfoobar
Copy link
Copy Markdown
Contributor Author

/assign @sttts

Signed-off-by: ehila <ehila@redhat.com>
@ggiguash
Copy link
Copy Markdown

/retest-required

@sttts
Copy link
Copy Markdown
Contributor

sttts commented Dec 20, 2021

/assign @atiratree @ingvagabund

updated library-go to latest for fix in pr openshift/library-go#1273

Signed-off-by: ehila <ehila@redhat.com>
@jerpeter1
Copy link
Copy Markdown
Member

/retest-required

2 similar comments
@ggiguash
Copy link
Copy Markdown

/retest-required

@ggiguash
Copy link
Copy Markdown

/retest-required

@ingvagabund
Copy link
Copy Markdown
Member

/retest

@ingvagabund
Copy link
Copy Markdown
Member

/retitle bug 2034484: feat: updated library-go and related deps

@openshift-ci openshift-ci Bot changed the title feat: updated library-go and related deps bug 2034484: feat: updated library-go and related deps Dec 26, 2021
@openshift-ci openshift-ci Bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Dec 26, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 26, 2021

@eggfoobar: This pull request references Bugzilla bug 2034484, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (jhou@redhat.com), skipping review request.

Details

In response to this:

bug 2034484: feat: updated library-go and related deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 26, 2021
@ingvagabund
Copy link
Copy Markdown
Member

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 26, 2021
@ingvagabund
Copy link
Copy Markdown
Member

@sttts for the approval

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 26, 2021

@eggfoobar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sttts
Copy link
Copy Markdown
Contributor

sttts commented Jan 3, 2022

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, ingvagabund, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2022
@openshift-merge-robot openshift-merge-robot merged commit 8e5b365 into openshift:master Jan 3, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 3, 2022

@eggfoobar: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2034484 has not been moved to the MODIFIED state.

Details

In response to this:

bug 2034484: feat: updated library-go and related deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants